[v14 backport] deps: V8: cherry-pick cc9a8a37445e #41826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
fix overflow check in error formatting
Bug: v8:12494
Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Gus Caplan <snek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78909}
Refs: v8/v8@cc9a8a3
|
Review requested:
|
nodejs-github-bot
added
build
gengjiawen
approved these changes
Feb 3, 2022
benjamingr
approved these changes
Feb 3, 2022
danielleadams
approved these changes
Feb 16, 2022
richardlau
force-pushed
the
v14.x-staging
branch
2 times, most recently
from
30ba86c
to
7f2825b
Compare
juanarbol
pushed a commit
that referenced
this pull request
Apr 28, 2022
Original commit message:
fix overflow check in error formatting
Bug: v8:12494
Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Gus Caplan <snek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78909}
Refs: v8/v8@cc9a8a3
PR-URL: #41826
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
|
Thank you! Landed in 39e44f8 🎉 |
juanarbol
added a commit
that referenced
this pull request
Apr 28, 2022
Notable changes V8: V8 had a stack overflow issue affecting the `vm` module, cherry-picking `941b023 from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting v8/v8@367b0c1 from V8. Learn more at: #42637 Contributed by Gabriel Schulhof (@legendecas) PR-url: TBD
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 1, 2022
Original commit message:
fix overflow check in error formatting
Bug: v8:12494
Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Gus Caplan <snek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78909}
Refs: v8/v8@cc9a8a3
PR-URL: #41826
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
juanarbol
added a commit
that referenced
this pull request
May 1, 2022
Notable Changes doc: * New release key for Bryan English Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 1, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 1, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 2, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 3, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 3, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (@devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 3, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 4, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 4, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@cc9a8a3